[New Feature] Smart duplicates

Discuss newly added features or request new features.
prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 01 Oct 2013, 09:05

Found a Bug:

After editing the dupekey/dupescore the new values aren't checked. Tested: Adding a download and adding an existing successfully downloaded item in History. I added the same or lower dupescore to the new item, this should normally remove the item form the download queue after saving as a dupe.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 01 Oct 2013, 10:19

Changing of dupekey/dupescore doesn't perform any actions other than changing/saving. The new values will be used by actions performed later like adding of new items or marking items as bad/good/etc.

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 01 Oct 2013, 10:25

The Problem with this is: That for manually added nzb's (Add Dialog) you can only add the dupekey/sore in that edit dialog after it's been added. So the dupecheck based on the values is never performed for such on item.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 01 Oct 2013, 10:38

If you want download a new title and have multiple nzb-files (duplicates) which you want queue manually:
  • add all files to queue (paused at best);
  • set duplicate keys/scores;
  • unpause the file you want try to download first (the one with the best score probably);
When the unpaused file completes the usual duplicate checks will be performed using assigned duplicate keys/scores.

If you just want to add a dupe (backup) into history I don't really see why you would want do that.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 01 Oct 2013, 21:01

Update:
  • improved parsing of multi-episodes from titles when generating dupekeys using item-options "rageid" or "series" and season/episode numbers (it's about new regex for "S08E23-E24");
  • fixed: when generating dupekeys with item-options "rageid" or "series" the season/episode numbers were not parsed from title if they were not used in the filter string.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 07 Oct 2013, 09:33

Important info:
automatic duplicate handling doesn't work well if option HealthCheck is set to Pause. In order to automatically unpause another duplicate (if first has failed) the option HealthCheck must be set either to Delete or None.

I'll change the default setting to Delete.

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 12 Oct 2013, 16:27

r875

There must be a bug in the webif history display... I have today a entry with: Dup but it the status says:

Code: Select all

 health: 100% Delete: dupe Cleanup: SUCCESS DeleteSamples: SUCCESS nzbToSickBeard: SUCCESS 
That makes no sense. The download was unpacked and postprocessed (the file is in the TV Show folder).

Sorry no log was active... And it makes no sense that the download was marked dupe and that unpack (it was unpakced) is missing in status. It had a dupekey and dupescore (set by my modified sickbeard via rpc-api), but the dupescore was higher as all already downloaded files.

I think I know what "happened" causing that error looking at the sickbeard history:
Saturday, 12.10.2013, 15:23:15 TV Show - 2x03 Downloaded EEE 1080p WEB-DL
Saturday, 12.10.2013, 13:55:21 TV Show - 2x03 Snatched provider1.org 1080p WEB-DL
Saturday, 12.10.2013, 13:45:57 TV Show - 2x03 Downloaded EEE 720p WEB-DL
Saturday, 12.10.2013, 13:40:37 TV Show - 2x03 Snatched provider3.org 1080p WEB-DL
Saturday, 12.10.2013, 11:54:04 TV Show - 2x03 Snatched provider2.org 1080p WEB-DL
Saturday, 12.10.2013, 10:09:01 TV Show - 2x03 Snatched provider1.org 720p WEB-DL
Because of some bug in sickbeard the higher quality was snatched 3 times (I know why it snatched it the third time, don't know why twice the first time). And somehow this confused nzbget. But it doesn't matter why sickbeard did it, nzbget's dupecheck did something wrong with it.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 12 Oct 2013, 17:10

After this history record was created and before you seen it was nzbget restarted? If it doesn't it would exclude a possibility of a bug in saving/restoring state. Otherwise it's a first suspect.

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 12 Oct 2013, 17:12

Nope, nzbget is running for almost 3 days now.
Uptime 2d 21:16:12

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: Some requests for a future version :-)

Post by prinz2311 » 15 Oct 2013, 09:24

Yes there must be a serious bug in it. Today I had one:

1080p:
dupe Tue Oct 15 2013 00:07:51
health: 100% Delete: dupe

dupescore:6400
and

720p:
success Tue Oct 15 2013 00:07:50
health: 100% Par: none Unpack: SUCCESS Cleanup: SUCCESS DeleteSamples: SUCCESS nzbToSickBeard: SUCCESS

dupescore:3200


So this time the download of the higher score was really aborted, the download folder has only some rar files. That is much more serious because this time it was not a displaying error, this time the better download was aborted.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests