[New Feature] Smart duplicates

Discuss newly added features or request new features.
hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 15 Oct 2013, 09:42

The previous error wasn't display error. It was probably a similar issue.

And you don't have any logs at all? That makes it hard to understand what is happening.
May be you could enable logging for few days? If you disable DebugTarget (it's not that important) the log-file should not be too big.

Thanks for reporting this.

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 15 Oct 2013, 09:48

I think i know what happened this time:

The lower dupescore download was already in postprocessing when the higher dupescore nzb was added, so nzbget could not pause the lower dupescore download anymore. And at the point when the lower finished the postprocessing nzbget removed the higher dupescore (still downloading) from the dowload queue. So the removing of dupes from the download queue after a download has finished probably doesn't check if the other dupes in the download queue have a higher score and are still downloading. This sound logically since the higher dupescore was 1 second after the lower score finshed removed and added to history.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 15 Oct 2013, 09:58

Checked the code that removes dupes from queue after the download is successfully completed. And it indeed doesn't check dupescore or paused/unpaused state.

I'll add a check so that only paused items will be removed from queue. I don't think a check for dupescore is necessary here. If user has manually unpaused an item with lower dupescore, it will remain in queue and be downloaded. Items with higher dupescores should be in unpaused state anyway.

Thanks for the analysis ;)

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 15 Oct 2013, 10:12

I think the first one was similar, just that in that case the higher was already downloaded and unpacked when the lower was finished postprocessing. So in that case the higher still was postprocessed and marked dupe in history. Or something like it...

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 17 Oct 2013, 19:10

Fixed in r879.

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 17 Oct 2013, 21:35

I think there is now a new logic error in it. Just now the 1080p web dl finished and the paused 720 web dl is still in the download queue and was not removed with the finished 1080 web dl.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 17 Oct 2013, 21:41

I'll check again.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 17 Oct 2013, 21:50

Does this 720p item have a health indicator (meaning it's below 100%)?

prinz2311
Posts: 464
Joined: 08 Dec 2012, 00:03

Re: [New Feature] Smart duplicates

Post by prinz2311 » 17 Oct 2013, 21:52

No. It was just paused during download when the higher 1080p was added. Health is at 100%.

hugbug
Developer & Admin
Posts: 7514
Joined: 09 Sep 2008, 11:58
Location: Germany

Re: [New Feature] Smart duplicates

Post by hugbug » 17 Oct 2013, 21:54

Oh. Then I made a mistake. I added a special check so that only downloads not having any downloaded files are removed.
This was not a good idea as I see now.

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests